| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Jun 2007 00:35:05 +0200 From: Pavel Machek <pavel@....cz> To: Nigel Cunningham <nigel@...el.suspend2.net> Cc: LKML <linux-kernel@...r.kernel.org>, Rafael Wysocki <rjw@...k.pl>, Andrew Morton <akpm@...l.org> Subject: Re: [PATCH] Optional Beeping During Resume From Suspend To Ram. Hi! > > > ALIGN > > > .align 4096 > > > @@ -31,6 +46,11 @@ wakeup_code: > > > movw %cs, %ax > > > movw %ax, %ds # Make ds:0 point to wakeup_start > > > movw %ax, %ss > > > + > > > + testl $1, beep_flags - wakeup_code > > > + jz 1f > > > + BEEP > > > +1: > > > > Can we rename/reuse existing flag variable? > > Sorry, but I can't resist the opportunity to say "Send a patch!" :) > > Seriously, though, I'd prefer not to. If we rename that acpi video flags > variable (I assume this is what you're thinking of), we only create cause for > confusion. A variable should for debugging or for controlling quirks, not for > both at the same time. Cause for confusion? We are currently using 2 bits of that variable, and we want to add one more bit. I seriously doubt that can confuse anyone. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists