linux-kernel - filemap.c: interesting check around zero_length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070629075632.GA5926@localhost.sw.ru>
Date:	Fri, 29 Jun 2007 11:56:32 +0400
From:	Alexey Dobriyan <adobriyan@...ru>
To:	linux-kernel@...r.kernel.org
Cc:	devel@...nvz.org
Subject: filemap.c: interesting check around zero_length_segment:

Adding -W -Wno-stupid-warnings results in the following warning:

mm/filemap.c: In function 'generic_file_buffered_write':
mm/filemap.c:2179: warning: comparison of unsigned expression >= 0 is always true

		if (likely(copied >= 0)) {
			if (!status)
				status = copied;

Branch is always taken since "copied" is size_t.

Such code doesn't exist in -mm, but is this something to worry about for
current and older kernels?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/