linux-kernel - Re: [PATCH 2/4 -mm] void unregister_blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40706292315v59d0fc4dnc64481d1746e306d@mail.gmail.com>
Date:	Sat, 30 Jun 2007 02:15:50 -0400
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Akinobu Mita" <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org,
	"Grant Likely" <grant.likely@...retlab.ca>
Subject: Re: [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message

On 6/29/07, Akinobu Mita <akinobu.mita@...il.com> wrote:
> No need to warn unregister_blkdev() failure by caller.
> (The previous patch makes unregister_blkdev() print error message in
> error case)
>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
Acked-by: Grant Likely <grant.likely@...retlab.ca>

>
> ---
>  drivers/block/xsysace.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: 2.6-mm/drivers/block/xsysace.c
> ===================================================================
> --- 2.6-mm.orig/drivers/block/xsysace.c
> +++ 2.6-mm/drivers/block/xsysace.c
> @@ -1157,9 +1157,7 @@ static void __exit ace_exit(void)
>  {
>         pr_debug("Unregistering Xilinx SystemACE driver\n");
>         driver_unregister(&ace_driver);
> -       if (unregister_blkdev(ace_major, "xsysace"))
> -               printk(KERN_WARNING "systemace unregister_blkdev(%i) failed\n",
> -                      ace_major);
> +       unregister_blkdev(ace_major, "xsysace");
>  }
>
>  module_init(ace_init);
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/