linux-kernel - Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707022113.46858.m.kozlowski@tuxland.pl>
Date:	Mon, 2 Jul 2007 21:13:45 +0200
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Nicolas Ferre <nicolas.ferre@....atmel.com>
Cc:	Pierre Ossman <drzeus@...eus.cx>,
	ARM Linux Mailing List 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Victor <andrew@...people.com>,
	Andreas Beier <mughat@...il.com>,
	Hamish Guthrie <hamish@...digi.ch>,
	Marc Pignat <marc.pignat@...s.ch>, wux@...dicorp.com,
	Patrice Vilchez <patrice.vilchez@....atmel.com>
Subject: Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

Hello,

> @@ -250,28 +246,27 @@ static void at91_mci_pre_dma_read(struct
>  /*
>   * Handle after a dma read
>   */
> -static void at91_mci_post_dma_read(struct at91mci_host *host)
> +static int at91_mci_post_dma_read(struct at91mci_host *host)
>  {
>         struct mmc_command *cmd;
>         struct mmc_data *data;
> +       int completed = 0;

You added 'completed' but you use it only once - as a return value.

>         pr_debug("post dma read done\n");
> +       return completed;
> }

What's the point?

	Mariusz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/