| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1183468191.29081.17.camel@shinybook.infradead.org> Date: Tue, 03 Jul 2007 09:09:50 -0400 From: David Woodhouse <dwmw2@...radead.org> To: Rodolfo Giometti <giometti@...eenne.com> Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH] LinuxPPS (with new syscalls API) - new version On Tue, 2007-07-03 at 11:48 +0200, Rodolfo Giometti wrote: > On Sun, Jul 01, 2007 at 01:03:11PM +0100, David Woodhouse wrote: > > > > Seems reasonable enough in principle -- but whatever you do, don't use > > "long" for it. That would definitely need different behaviour for 32-bit > > vs. 64-bit. Use explicitly sized types such as uint32_t or uint64_t. > > Here the patch to convert LinuxPPS data structs into fixed ones. > > Please, take a look at it and report possible modifications. Looks relatively sane at first glance; busy this week so haven't looked very hard yet. Two thing though... you're mixing proper C types (uint32_t) and the Linux-specific legacy crap types (__u32). Pick one. I won't recommend _which_ one, because if I do I'll make Andrew unhappy. But pick one; don't use both at the same time. Also read Documentation/volatile-considered-harmful.txt and ponder deeply your use of 'volatile' on certain members of struct pps_s. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists