lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Jul 2007 15:28:04 +0100 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: akpm@...l.org, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, paulkf@...rogate.com Subject: [PATCH] synclink: Remove bogus 'no change' termios optimisation from synclink drivers Again this check is wrong now, and un-needed Signed-off-by: Alan Cox <alan@...hat.com> diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclink.c linux-2.6.22-rc6-mm1/drivers/char/synclink.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclink.c 2007-07-02 20:48:49.000000000 +0100 +++ linux-2.6.22-rc6-mm1/drivers/char/synclink.c 2007-07-02 21:06:50.000000000 +0100 @@ -160,8 +160,6 @@ #define IO_PIN_SHUTDOWN_LIMIT 100 -#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) - struct _input_signal_events { int ri_up; int ri_down; @@ -3064,12 +3062,6 @@ printk("%s(%d):mgsl_set_termios %s\n", __FILE__,__LINE__, tty->driver->name ); - /* just return if nothing has changed */ - if ((tty->termios->c_cflag == old_termios->c_cflag) - && (RELEVANT_IFLAG(tty->termios->c_iflag) - == RELEVANT_IFLAG(old_termios->c_iflag))) - return; - mgsl_change_params(info); /* Handle transition to B0 status */ diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclink_gt.c linux-2.6.22-rc6-mm1/drivers/char/synclink_gt.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclink_gt.c 2007-07-02 20:48:49.000000000 +0100 +++ linux-2.6.22-rc6-mm1/drivers/char/synclink_gt.c 2007-07-02 21:06:50.000000000 +0100 @@ -144,8 +144,6 @@ /* * tty support and callbacks */ -#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) - static struct tty_driver *serial_driver; static int open(struct tty_struct *tty, struct file * filp); @@ -823,12 +821,6 @@ DBGINFO(("%s set_termios\n", tty->driver->name)); - /* just return if nothing has changed */ - if ((tty->termios->c_cflag == old_termios->c_cflag) - && (RELEVANT_IFLAG(tty->termios->c_iflag) - == RELEVANT_IFLAG(old_termios->c_iflag))) - return; - change_params(info); /* Handle transition to B0 status */ diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclinkmp.c linux-2.6.22-rc6-mm1/drivers/char/synclinkmp.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/char/synclinkmp.c 2007-07-02 20:47:23.000000000 +0100 +++ linux-2.6.22-rc6-mm1/drivers/char/synclinkmp.c 2007-07-02 21:06:50.000000000 +0100 @@ -135,8 +135,6 @@ #define IO_PIN_SHUTDOWN_LIMIT 100 -#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK)) - struct _input_signal_events { int ri_up; int ri_down; @@ -927,12 +925,6 @@ printk("%s(%d):%s set_termios()\n", __FILE__,__LINE__, tty->driver->name ); - /* just return if nothing has changed */ - if ((tty->termios->c_cflag == old_termios->c_cflag) - && (RELEVANT_IFLAG(tty->termios->c_iflag) - == RELEVANT_IFLAG(old_termios->c_iflag))) - return; - change_params(info); /* Handle transition to B0 status */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists