linux-kernel - Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <468A5F89.70900@sourcepoet.org>
Date:	Tue, 03 Jul 2007 16:39:05 +0200
From:	Morten Helgesen <morten@...rcepoet.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] genericserial: Remove bogus optimisation check and dead
 code paths

Alan Cox wrote:

[...snip...]
> @@ -75,11 +64,11 @@
>  	if (! (port->flags & ASYNC_INITIALIZED)) return;
>  
>  	/* Take a lock on the serial tranmit buffer! */
> -	LOCKIT;
> +	mutex_lock(& port->port_write_mutex);
>   

^ Contains additional whitespace.

>  	if (port->xmit_cnt >= SERIAL_XMIT_SIZE - 1) {
>  		/* Sorry, buffer is full, drop character. Update statistics???? -- REW */
> -		RELEASEIT;
> +		mutex_unlock(&port->port_write_mutex);
>  		return;
>  	}
>  
> @@ -87,13 +76,11 @@
>   
[...snip...]

== Morten
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/