linux-kernel - Re: checkpatch: need space before that '*' (ctx:BxB)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Jul 2007 16:19:40 +0100
From:	Andy Whitcroft <andyw@...ibm.com>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
CC:	Trilok Soni <soni.trilok@...il.com>,
	Andy Whitcroft <APW@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch: need space before that '*' (ctx:BxB)

Jan Engelhardt wrote:
> On Jun 27 2007 17:24, Trilok Soni wrote:
>> In the following case we may not need space before that "(*)". It
>> looks like false positive. Please check.
>>
>> need space before that '*' (ctx:BxB)
>> #1034: FILE: drivers/video/omap/omapfb.c:968:
>> +       omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
>>                                                          ^
> 
> The line, as presented in your mail, is already correct
> Keep the space between "int" and "(*)"  :-)
> [follows how you'd declare a normal variable]
> 
> 
> 	Jan

Yep this was a falsie.  This was fixed in the recent 0.06 release.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/