| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070703052856.GA1657@ff.dom.local> Date: Tue, 3 Jul 2007 07:28:56 +0200 From: Jarek Poplawski <jarkao2@...pl> To: Oleg Nesterov <oleg@...sign.ru> Cc: Andrew Morton <akpm@...ux-foundation.org>, David Howells <dhowells@...hat.com>, Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] rename cancel_rearming_delayed_work() to cancel_delayed_work_sync() On Sun, Jul 01, 2007 at 07:36:29PM +0400, Oleg Nesterov wrote: > Imho, the current naming of cancel_xxx workqueue functions is very confusing. > > cancel_delayed_work() > cancel_rearming_delayed_work() > cancel_rearming_delayed_workqueue() // obsolete > > cancel_work_sync() > > This looks as if the first 2 functions differ in "type" of their argument which > is not true any longer, nowadays the difference is the behaviour. > > The semantics of cancel_rearming_delayed_work(dwork) was changed significantly, > it doesn't require that dwork rearms itself, and cancels dwork synchronously. > > Rename it to cancel_delayed_work_sync(). This matches cancel_delayed_work() and > cancel_work_sync(). Re-create cancel_rearming_delayed_work() as a simple inline > obsolete wrapper, like cancel_rearming_delayed_workqueue(). > > Signed-off-by: Oleg Nesterov <oleg@...sign.ru> Acked-by: Jarek Poplawski <jarkao2@...pl> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists