linux-kernel - Re: Don't miss the ARM-scsi fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070703193104.GA27542@flint.arm.linux.org.uk>
Date:	Tue, 3 Jul 2007 20:31:04 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rob Landley <rob@...dley.net>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: Don't miss the ARM-scsi fix.

On Tue, Jul 03, 2007 at 12:21:45PM -0700, Andrew Morton wrote:
> On Tue, 3 Jul 2007 15:03:56 -0400
> Rob Landley <rob@...dley.net> wrote:
> 
> > Just making sure this fix winds up in 2.6.23:
> 
> 2.6.22?
> 
> > http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=4454/1
> > 
> > It fixes a regression that occurred between 2.6.20 and 2.6.20-rc1.  Without 
> > it, qemu-system-arm can't use emulated SCSI drives.  It wasn't in -rc7, and 
> > the attached patch Works For Me (tm).
> 
> Should have cc'ed Russell?

It's been applied and is in my tree since yesterday.  I've no idea why
Rob feels that he needs to pull patches out of the patch system.

> > diff --git a/arch/arm/mach-versatile/pci.c b/arch/arm/mach-versatile/pci.c
> > index ba58223..ca82901 100644
> > --- a/arch/arm/mach-versatile/pci.c
> > +++ b/arch/arm/mach-versatile/pci.c
> > @@ -117,7 +117,10 @@ static int versatile_read_config(struct pci_bus *bus, unsigned int devfn, int wh
> >  	} else {
> >  		switch (size) {
> >  		case 1:
> > -			v = __raw_readb(addr);
> > +			v = __raw_readl(addr);
> > +			if (where & 2) v >>= 16;
> > +			if (where & 1) v >>= 8;
> 
> Someone's enter key broke?

Probably, but I'd rather have the fix in than worry about that at this
stage.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/