linux-kernel - Re: [PATCH 2/4] scsi: megaraid_sas -- add module param fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070703144522.6b65f626.akpm@linux-foundation.org>
Date:	Tue, 3 Jul 2007 14:45:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	bo yang <bo.yang@....com>
Cc:	James.Bottomley@...elEye.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, neela.kolli@....com,
	sumant.patro@....com
Subject: Re: [PATCH 2/4] scsi: megaraid_sas -- add module param fast_load

On Sun, 01 Jul 2007 12:42:33 -0400
bo yang <bo.yang@....com> wrote:

> Driver will skip physical devices scan for the first time if the
> fast_load is set.
> 

All your patches are wordwrapped and will need to be resent.

Also, there are multiple trivial errors in here, pretty much all of which
would have been detected had you run scripts/checkpatch.pl across the
diffs:

> + */
> +static unsigned int fast_load = 0;

Unneeded initialisation

> +static int megasas_slave_alloc(struct scsi_device *sdev) {

Missing newline

> +	struct megasas_instance *instance ;

unneeded space

> +	int tmp_fastload = fast_load;
> +	instance = megasas_lookup_instance(sdev->host->host_no);

Missing blank line.

> +	if (tmp_fastload && sdev->channel < MEGASAS_MAX_PD_CHANNELS) {
> +		if ((sdev->id == MEGASAS_MAX_DEV_PER_CHANNEL -1) &&
> +			(sdev->channel == MEGASAS_MAX_PD_CHANNELS - 1)) {
> +			/* If fast load option was set and scan for last device is
> +			 * over, reset the fast_load flag so that during a possible
> +			 * next scan, devices can be made available
> +			 */
> +			fast_load = 0;
> +		}
> +		return -ENXIO;
> +	}
> +
> +	return 0;
> +}
> +

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/