linux-kernel - Re: [PATCH 1/4] scsi: megaraid_sas -- add hibernation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070703151604.dbd0c9a8.akpm@linux-foundation.org>
Date:	Tue, 3 Jul 2007 15:16:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	bo yang <bo.yang@....com>
Cc:	James.Bottomley@...elEye.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, neela.kolli@....com,
	sumant.patro@....com
Subject: Re: [PATCH 1/4] scsi: megaraid_sas -- add hibernation support

On Sun, 01 Jul 2007 12:31:23 -0400
bo yang <bo.yang@....com> wrote:

> The megaraid_sas driver doesn't support the hibernation, the
> suspend/resume routine implemented to support the hibernation.
> 
> Signed-off-by: Bo Yang <bo.yang@....com>
> 
> ---
> 
> drivers/scsi/megaraid/megaraid_sas.c |  308 +++++++++++++++++++------
> drivers/scsi/megaraid/megaraid_sas.h |    1
> 2 files changed, 239 insertions(+), 70 deletions(-)
> 
> diff -rupN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c
> linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c
> --- linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c 2007-06-20
> 02:18:24.000000000 -0400
> +++ linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c 2007-06-30
> 03:21:27.000000000 -0400

wordwrapped.

> @@ -1804,6 +1804,81 @@ static void megasas_complete_cmd_dpc(uns
>  }
>  
>  /**
> + * megasas_issue_init_mfi - Initializes the FW
> + * @instance:  Adapter soft state
> + *
> + * Issues the INIT MFI cmd
> + */
> +static int
> +megasas_issue_init_mfi(struct megasas_instance *instance)
> +{
> + u32 context;
> +
> + struct megasas_cmd *cmd;
> +
> + struct megasas_init_frame *init_frame;
> + struct megasas_init_queue_info *initq_info;
> + dma_addr_t init_frame_h;
> + dma_addr_t initq_info_h;

Please use tabs, not spaces.

> +	/*
> +	 * Prepare a init frame. Note the init frame points to queue info
> +	 * structure. Each frame has SGL allocated after first 64 bytes. For
> +	 * this frame - since we don't need any SGL - we use SGL's space as
> +	 * queue info structure
> +	 *
> +	 * We will not get a NULL command below. We just created the pool.
> +	 */
> +	cmd = megasas_get_cmd(instance);
> +
> +	init_frame = (struct megasas_init_frame *)cmd->frame;
> +	initq_info = (struct megasas_init_queue_info *)
> +	    ((unsigned long)init_frame + 64);
> +
> +	init_frame_h = cmd->frame_phys_addr;
> +	initq_info_h = init_frame_h + 64;
> +
> +	context = init_frame->context;
> +	memset(init_frame, 0, MEGAMFI_FRAME_SIZE);
> +	memset(initq_info, 0, sizeof(struct megasas_init_queue_info));
> +	init_frame->context = context;
> +
> +	initq_info->reply_queue_entries = instance->max_fw_cmds + 1;
> +	initq_info->reply_queue_start_phys_addr_lo = instance->reply_queue_h;
> +
> +	initq_info->producer_index_phys_addr_lo = instance->producer_h;
> +	initq_info->consumer_index_phys_addr_lo = instance->consumer_h;
> +
> +	init_frame->cmd = MFI_CMD_INIT;
> +	init_frame->cmd_status = 0xFF;
> +	init_frame->queue_info_new_phys_addr_lo = initq_info_h;
> +
> +	init_frame->data_xfer_len = sizeof(struct megasas_init_queue_info);
> +
> +	/*
> +	 * disable the intr before firing the init frame to FW
> +	 */
> +	instance->instancet->disable_intr(instance->reg_set);
> +
> +	/*
> +	 * Issue the init frame in polled mode
> +	 */
> +
> +	if (megasas_issue_polled(instance, cmd)) {
> +		printk(KERN_DEBUG "megasas: Failed to init firmware\n");

I'd have though KERN_ERR was appropriate here?

> +		megasas_return_cmd(instance, cmd);
> +		goto fail_fw_init;
> +	}
> +
> +	megasas_return_cmd(instance, cmd);
> +
> +	return 0;
> +
> +	fail_fw_init:
> +		return -EINVAL;
> +}
>
> ..
>
> -	if (megasas_issue_polled(instance, cmd)) {
> -		printk(KERN_DEBUG "megasas: Failed to init firmware\n");

hm, it was KERN_DEBUG before.  Perhaps that was wrong.

> +static int
> +megasas_set_dma_mask(struct pci_dev *pdev)
> +{
> +	/*
> +	 * All our contollers are capable of performing 64-bit DMA
> +	 */
> +	if (IS_DMA64) {

Bah.

#define IS_DMA64 (sizeof(dma_addr_t) == 8)

that should not be in a driver-private header file.

> +
> +      fail_irq:
> +      fail_init_mfi:

Opinions vary, but we usually indent labels by zero or one spaces.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/