linux-kernel - Re: Fix empty macros in acpi.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070703054455.GB32110@redhat.com>
Date:	Tue, 3 Jul 2007 01:44:55 -0400
From:	Dave Jones <davej@...hat.com>
To:	Len Brown <lenb@...nel.org>
Cc:	Al Viro <viro@....linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Fix empty macros in acpi.

On Tue, Jul 03, 2007 at 01:22:47AM -0400, Len Brown wrote:

 > whelp, it seems that the reason for this patch is this:
 > 
 > #define DBG()
 > 
 > if(...)
 > 	DBG();
 > next_c_statement
 > 
 > which turns into
 > if(...) ;
 > next_c_statement
 > 
 > But since there is an intervening ';', this code is still functionally correct
 > and a decent compiler will delete the test altogether, yes?

Right, gcc does generate the correct code.

 > So is there some real problem here that I missed,
 > or is this to make some code-checking tool that I don't have happy?

Out of curiousity, I thought I'd see what was lurking in a -Wextra
build a while back. It's 99.9% noise, but a lot of it is trivial stuff
like this.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/