linux-kernel - Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jul 2007 21:53:39 +0900
From:	"Akinobu Mita" <akinobu.mita@...il.com>
To:	"Jan-Bernd Themann" <ossthema@...ibm.com>
Cc:	"Jeff Garzik" <jeff@...zik.org>, netdev <netdev@...r.kernel.org>,
	"Christoph Raisch" <raisch@...ibm.com>,
	"Jan-Bernd Themann" <themann@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ppc <linuxppc-dev@...abs.org>,
	"Marcus Eder" <meder@...ibm.com>,
	"Thomas Klein" <tklein@...ibm.com>,
	"Stefan Roscher" <stefan.roscher@...ibm.com>
Subject: Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007/7/4, Jan-Bernd Themann <ossthema@...ibm.com>:

> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index bdb5241..f8c0908 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2923,6 +2923,15 @@ static int check_module_parm(void)
>         return ret;
>  }
>
> +static ssize_t ehea_show_capabilities(struct device_driver *drv,
> +                                     char *buf)
> +{
> +       return sprintf(buf, "%d", EHEA_CAPABILITIES);
> +}
> +
> +static DRIVER_ATTR(capabilities, S_IRUSR | S_IRGRP | S_IROTH,
> +                  ehea_show_capabilities, NULL);
> +
>  int __init ehea_module_init(void)
>  {
>         int ret;
> @@ -2937,12 +2946,20 @@ int __init ehea_module_init(void)
>         if (ret)
>                 ehea_error("failed registering eHEA device driver on ebus");
>

You forgot to put:
                return ret;
or
                goto out;

> +       ret = driver_create_file(&ehea_driver.driver, &driver_attr_capabilities);
> +       if (ret) {
> +               ehea_error("failed to register capabilities attribute, ret=%d", ret);
> +               ibmebus_unregister_driver(&ehea_driver);
> +               goto out;
> +       }
> +
>  out:
>         return ret;
>  }
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/