linux-kernel - [RFC] disabling RTC irq during release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070704170753.GO10397@enneenne.com>
Date:	Wed, 4 Jul 2007 19:07:53 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	linux-kernel@...r.kernel.org
Subject: [RFC] disabling RTC irq during release

Hello,

Looking at other rtc drivers I noticed that during the release()
method we should disable IRQs as follow:

static void ds1307_release(struct device *dev)
{
        struct ds1307   *ds1307 = dev_get_drvdata(dev);

        if (ds1307->irq >= 0) {
                ds1307->irqen = 0;
                ds1307_update_alarm(ds1307);
        }
}

that's the code I put into my patch for ds1339.

But if I wish using RTC IRQ line to turn also the board ON, not just
to put to sleep it, I should leave the IRQ line on!

I think we should add a configuration option who allows developers to
choose if the RTC IRQ line should be disabled or not during release().

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/