linux-kernel - Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jul 2007 23:44:24 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	seife@...e.de, nigel@...el.suspend2.net,
	linux-kernel@...r.kernel.org, suspend-devel@...ts.sourceforge.net
Subject: Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

On Wednesday, 4 July 2007 21:33, Pavel Machek wrote:
> Hi!
> 
> > > What about this? (Only compile tested, but looks pretty obvious to
> > > me). Something like this should get us rid of ugly option, and still
> > > solve debugging problems... Hmmm?
> > > 								Pavel
> > > 
> > > Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at
> > > all, instead, we should automatically keep console alive when
> > > possible.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@...e.cz>
> > > 
> > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> > > index 62051f8..8267ff8 100644
> > > --- a/drivers/char/lp.c
> > > +++ b/drivers/char/lp.c
> > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0;
> > >  static struct class *lp_class;
> > >  
> > >  #ifdef CONFIG_LP_CONSOLE
> > > -static struct parport *console_registered; // initially NULL
> > > +static struct parport *console_registered;
> > >  #endif /* CONFIG_LP_CONSOLE */
> > 
> > Could you please avoid fixing things like this, white space etc. in this patch?
> > It would be easier to read ...
> 
> Yep, sorry, it should be separate patch. I hope the idea is still
> simple enough.

Yes, but I'm not sure if netconsole is the only one that we will want to have
disabled.  Moreover, what if someone wants to use the netconsole regardless
of the fact that it can crash the box?

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/