[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <468CEAEC.7040102@bx.jp.nec.com>
Date: Thu, 05 Jul 2007 21:58:20 +0900
From: Keiichi KII <k-keiichi@...jp.nec.com>
To: Satyam Sharma <ssatyam@....iitk.ac.in>
CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Netdev <netdev@...r.kernel.org>,
Joel Becker <joel.becker@...cle.com>,
Matt Mackall <mpm@...enic.com>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>
Subject: Re: [PATCH -mm 8/9] netconsole: Update documentation for dynamic
reconfigurability
Hi Satyam,
> + cat enabled # check if enabled is 1
> + echo 0 > enabled # disable the target (if required)
> + echo eth2 > dev_name # set local interface
I think that the above line should change from "echo eth2 > dev_name" to
"echo -n eth2 > dev_name" or the newline should be removed at store_dev_name().
The default behavior of echo(1) outputs the newline.
So, if we write appropriate network device name to dev_name,
the netpoll can't find net_device in netpoll_setup().
I don't have enough time now. So I will check your patches more specific
at the weekend.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: k-keiichi@...jp.nec.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists