linux-kernel - Re: [PATCH 2/2] workqueue: debug work related deadlocks with lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070705153648.GA236@tv-sign.ru>
Date:	Thu, 5 Jul 2007 19:36:48 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/2] workqueue: debug work related deadlocks with lockdep

On 07/05, Johannes Berg wrote:
>
> +#define __WORK_INIT_LOCKDEP_MAP(n, k) \
> +	.lockdep_map = STATIC_LOCKDEP_MAP_INIT(n, k),
> +#else
> +#define __WORK_INIT_LOCKDEP_MAP(n, k)
> +#endif
> +
>  #define __WORK_INITIALIZER(n, f) {				\
>  	.data = WORK_DATA_INIT(),				\
>  	.entry	= { &(n).entry, &(n).entry },			\
>  	.func = (f),						\
> +	__WORK_INIT_LOCKDEP_MAP(#n, &(n))			\

[...snip...]

> +#define STATIC_LOCKDEP_MAP_INIT(_name, _key) \
> +	{ .name = (_name), .key = (void *)(_key), }

Hmm... Can't understand, please help!

So, __WORK_INITIALIZER() uses work_struct itself as a "struct lock_class_key" ?
How so?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/