linux-kernel - Re: [PATCH 10/11] drivers/block/rd.c: lower printk severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070705105942.ec6396fe.randy.dunlap@oracle.com>
Date:	Thu, 5 Jul 2007 10:59:42 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Dan Aloni <da-x@...atomic.org>
Cc:	Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/11] drivers/block/rd.c: lower printk severity

On Wed, 4 Jul 2007 15:30:22 +0300 Dan Aloni wrote:

> Signed-off-by: Dan Aloni <da-x@...atomic.org>
> ---
>  drivers/block/rd.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/rd.c b/drivers/block/rd.c
> index a1512da..3b974f8 100644
> --- a/drivers/block/rd.c
> +++ b/drivers/block/rd.c
> @@ -463,9 +463,9 @@ static int __init rd_init(void)
>  	}
>  
>  	/* rd_size is given in kB */
> -	printk("RAMDISK driver initialized: "
> -		"%d RAM disks of %dK size %d blocksize\n",
> -		CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
> +	printk(KERN_INFO "RAMDISK driver initialized: "
> +	       "%d RAM disks of %dK size %d blocksize\n",
> +	       CONFIG_BLK_DEV_RAM_COUNT, rd_size, rd_blocksize);
>  
>  	return 0;
>  out:
> -- 

Hi Dan,
All of the changes look good to me except for this one.
The change to use 7 spaces to align the strings is unnecessary.

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/