| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Jul 2007 20:43:44 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Pavel Machek <pavel@....cz> Cc: Nigel Cunningham <nigel@...el.suspend2.net>, nigel@...pend2.net, LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org> Subject: Re: [PATCH] Optional Beeping During Resume From Suspend To Ram. On Thursday, 5 July 2007 01:25, Pavel Machek wrote: > > > > > > > Beep_flags should be removed too if you're sticking with /proc. > > > > > > > > > > Fixed. > > > > > > > > Ta. But you didn't answer the question - why /proc and not sysfs? > > > > > > Do you seriously advocate setting two bits of one variable from /proc, > > > and one more bit from /sys? > > > > That's partly why I had a separate variable - retaining proc only because it's > > existing functionality, using sysfs for the new code. Remember, too, that > > /proc is not deprecated _that_ much, and notice that this is sysctl, > not regular procfs code. > > Yes, I see why you did it that way, but I also think you overdisgned > it a bit. Hmm, what about adding a second interface to acpi_realmode_flags in sysfs, in a separate patch, and scheduling the old one, in /proc, for removal? Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists