linux-kernel - Re: [PATCH -mm 5/9] netconsole: Introduce dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070705063904.GG17650@tasint.org>
Date:	Wed, 4 Jul 2007 23:39:05 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Satyam Sharma <ssatyam@....iitk.ac.in>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Keiichi Kii <k-keiichi@...jp.nec.com>,
	Netdev <netdev@...r.kernel.org>, Matt Mackall <mpm@...enic.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
> -	if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> -		goto done;
> +	if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> +	      event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> +	      	goto done;
>
>  	if (nt->np.dev == dev) {
>  		switch (event) {

	It's a small nit, but isn't the large if() just the degenerate
default case of the switch()?  Why have it at all?  

Joel

-- 

Life's Little Instruction Book #396

	"Never give anyone a fruitcake."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/