[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1183626507.3818.19.camel@johannes.berg>
Date: Thu, 05 Jul 2007 11:08:27 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Ingo Molnar <mingo@...e.hu>,
Linux Kernel list <linux-kernel@...r.kernel.org>,
Oleg Nesterov <oleg@...sign.ru>,
Arjan van de Ven <arjan@...radead.org>,
Thomas Sattler <tsattler@....de>
Subject: Re: [PATCH] debug work struct cancel deadlocks with lockdep
On Thu, 2007-07-05 at 11:01 +0200, Peter Zijlstra wrote:
> You could of course make this STATIC_LOCKDEP_MAP_INIT() and place it
> near lockdep_init_map() :-)
>
> That way it would be clear that changes to either ought to be reflected
> in the other.
Sure. I have to repost anyway :)
How about
+/* both _name and _key must not be NULL */
+#define STATIC_LOCKDEP_MAP_INIT(_name, _key) \
+ { .name = (_name), .key = (_key), }
That'll still require some #ifdef foo inside workqueue.h but I think
it's cleaner to put just this into lockdep.h
johannes
Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)
Powered by blists - more mailing lists