linux-kernel - Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92a12cdb0707060246p407f19depe16c59ac43eb0d96@mail.gmail.com>
Date:	Fri, 6 Jul 2007 10:46:59 +0100
From:	"Adrian McMenamin" <adrianmcmenamin@...il.com>
To:	"Takashi Iwai" <tiwai@...e.de>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions

On 06/07/07, Takashi Iwai <tiwai@...e.de> wrote:
> At Thu, 5 Jul 2007 23:07:44 +0100,
> Adrian McMenamin wrote:
> > @@ -402,17 +396,10 @@
> >  static int snd_aicapcm_pcm_trigger(struct snd_pcm_substream
> >                                  *substream, int cmd)
> >  {
> > -     struct snd_card_aica *dreamcastcard;
> >       switch (cmd) {
> >       case SNDRV_PCM_TRIGGER_START:
> >               spu_begin_dma(substream);
> >               break;
> > -     case SNDRV_PCM_TRIGGER_STOP:
> > -             dreamcastcard = substream->pcm->private_data;
> > -             if (dreamcastcard->timer.data)
> > -                     del_timer(&dreamcastcard->timer);
> > -             aica_chn_halt();
> > -             break;
> >       default:
> >               return -EINVAL;
> >       }
>
> Is this a correct change?  Then you'd have no control for stopping the
> stream.
>

The shutdown is all done in the close() now, partly because
snd_aicapcm_pcm_trigger cannot sleep and close() can. Is there a
pressing reason to put code in snd_aicapcm_pcm_trigger?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/