lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <92a12cdb0707060309x6fe997nc3112d5545d73ef5@mail.gmail.com>
Date:	Fri, 6 Jul 2007 11:09:00 +0100
From:	"Adrian McMenamin" <adrianmcmenamin@...il.com>
To:	"Takashi Iwai" <tiwai@...e.de>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions

On 06/07/07, Takashi Iwai <tiwai@...e.de> wrote:
> I guess you shoud call del_timer() there at least.  Otherwise the
> timer handler (aica_period_elapsed()) might be called even if the
> stream is not really running.
>

Fair enough. I'll fix that and repost later.

> The below is some coding style fixes, BTW.  I'm not sure whether
> queue_work() is intended in the block if "if (dma_check == 0)" or
> not.
>

It's just an aberrant indent - I think there was an independent block
there in earlier code, it got removed but the tab stayed :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ