linux-kernel - Re: [PATCH 1/3] GEODE: basic infrastructure support for AMD geode-class machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <468E49C9.3000200@shadowen.org>
Date:	Fri, 06 Jul 2007 14:55:21 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Andres Salomon <dilinger@...ued.net>, linux-kernel@...r.kernel.org,
	Jordan Crouse <jordan.crouse@....com>
Subject: Re: [PATCH 1/3] GEODE: basic infrastructure support for AMD geode-class
 machines

Andrew Morton wrote:
> The patches have some trivial-but-common coding-style bloopers which
> scripts/checkpatch.pl will detect.  Please check it out.
> oh

> Please send a patch which documents mfgpt_irq in
> Documentation/kernel-parameters.txt, thanks.
> 
> Andy, the miss rate on documentation for new __setup() handlers is about
> 75%.  Might be worth adding to checkpatch.pl.

If we are willing to expect the update in the same patch then we can
emit a failure if the presented string in __check isn't in the update to
the documentation.  I guess emit it as a CHECK in case they have loads
of them and a separate documentation patch.

CHECK: __setup appears un-documented -- check
			Documentation/kernel-parameters.txt
#131: FILE: arch/i386/kernel/mfgpt.c:233:
+__setup("mfgpt_irq=", mfgpt_setup);

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/