linux-kernel - Re: [PATCH] I386: Deactivate the test for the dead CONFIG_BALANCED_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0707060957390.27008@localhost.localdomain>
Date:	Fri, 6 Jul 2007 10:00:36 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] I386: Deactivate the test for the dead CONFIG_BALANCED_IRQ_DEBUG
 variable.

On Fri, 6 Jul 2007, Stefan Richter wrote:

> Robert P. J. Day wrote:
> > --- a/arch/i386/kernel/io_apic.c
> > +++ b/arch/i386/kernel/io_apic.c
> > @@ -353,7 +353,7 @@ static void set_ioapic_affinity_irq(unsigned int irq, cpumask_t cpumask)
> >  # include <linux/slab.h>		/* kmalloc() */
> >  # include <linux/timer.h>	/* time_after() */
> >
> > -#ifdef CONFIG_BALANCED_IRQ_DEBUG
> > +#if 0 /* debug IRQ balancing */
> >  #  define TDprintk(x...) do { printk("<%ld:%s:%d>: ", jiffies, __FILE__, __LINE__); printk(x); } while (0)
> >  #  define Dprintk(x...) do { TDprintk(x); } while (0)
> >  # else
>
> Regarding the Subject:  Perhaps it's not of type "dead (K)config
> variable"in the strict sense but rather of the type "local macro
> whose name was unbefittingly taken from CONFIG_ namespace".
>
> BTW, when I suggested the "#if 0" to you, I forgot that some
> developers might be interested in compiling their kernel with
> -DCONFIG_BALANCED_IRQ_DEBUG injected via the commandline. But we'll
> hear from them if that's the case.
>
> On the other hand, these debug macros seem to be very old.  I'll
> have a closer look with qgit/git-blame later today.  Maybe it's time
> to remove them now.

ok, why don't i leave all that in your capable hands?  typically, when
i describe a CONFIG_ prefixed variable as "dead", it's because it's
not being set *anywhere* in the tree -- not in a Kconfig file or a
header file or a source file or a Makefile.

so i'm not just checking for its existence in a Kconfig file.  i
learned that lesson.  :-)

rday

p.s.  and i've bitched and moaned about this before, but anyone who
deliberately names their debugging variables with a "CONFIG_" prefix
*deserves* to have their builds break.  :-P

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/