linux-kernel - Re: [PATCH] mm: fixup /proc/vmstat output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070706171837.GA5763@martell.zuzino.mipt.ru>
Date:	Fri, 6 Jul 2007 21:18:37 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Fengguang Wu <wfg@...l.ustc.edu.cn>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Lameter <clameter@....com>, riel <riel@...hat.com>
Subject: Re: [PATCH] mm: fixup /proc/vmstat output

On Fri, Jul 06, 2007 at 01:35:34PM +0200, Peter Zijlstra wrote:
> Line up the vmstat_text with zone_stat_item
> 
> enum zone_stat_item {
> 	/* First 128 byte cacheline (assuming 64 bit words) */
> 	NR_FREE_PAGES,
> 	NR_INACTIVE,
> 	NR_ACTIVE,
> 
> We current have nr_active and nr_inactive reversed.

OK with patch, though using initializers canbe handy to prevent such
things in future:

	static const char * const vmstat_text[] = {
		[NR_FREE_PAGES] = "nr_free_pages",
		...

> --- linux-2.6.orig/mm/vmstat.c
> +++ linux-2.6/mm/vmstat.c
> @@ -700,8 +700,8 @@ const struct seq_operations pagetypeinfo
>  static const char * const vmstat_text[] = {
>  	/* Zoned VM counters */
>  	"nr_free_pages",
> -	"nr_active",
>  	"nr_inactive",
> +	"nr_active",
>  	"nr_anon_pages",
>  	"nr_mapped",
>  	"nr_file_pages",

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/