linux-kernel - Re: [PATCH] mm: double mark_page_accessed() in read_cache_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070706155647.3056f1f5.akpm@linux-foundation.org>
Date:	Fri, 6 Jul 2007 15:56:47 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Nick Piggin <npiggin@...e.de>, riel <riel@...hat.com>
Subject: Re: [PATCH] mm: double mark_page_accessed() in
 read_cache_page_async()

On Fri, 06 Jul 2007 18:03:54 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> read_cache_page_async() seems to have two invocations of
> mark_page_accessed() which will launch pages right onto the active list.
> 
> Remove the first one, keeping the latter one. This avoids marking
> unwanted pages active (in the retry loop).
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
>  mm/filemap.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-2.6/mm/filemap.c
> ===================================================================
> --- linux-2.6.orig/mm/filemap.c
> +++ linux-2.6/mm/filemap.c
> @@ -1588,7 +1588,6 @@ retry:
>  	page = __read_cache_page(mapping, index, filler, data);
>  	if (IS_ERR(page))
>  		return page;
> -	mark_page_accessed(page);
>  	if (PageUptodate(page))
>  		goto out;
>  
> 

Thanks for catching this.  It is a post-2.6.21 regression.

We cannot afford to do stuff like this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/