[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 7 Jul 2007 23:11:10 +0200
From: Adrian Bunk <bunk@...sta.de>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Patrick Caulfield <pcaulfie@...hat.com>,
Steven Whitehouse <swhiteho@...hat.com>, teigland@...hat.com,
cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [2.6.22 regression fix] DLM must depend on SYSFS
On Sat, Jul 07, 2007 at 01:51:55PM -0700, Linus Torvalds wrote:
>
>
> On Sat, 7 Jul 2007, Adrian Bunk wrote:
> >
> > The dependency of DLM on SYSFS got lost in
> > commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the
> > following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:
>
> Hmm. Shouldn't we make that a "select", the way we already do for
> CONFIGFS_FS?
"select" is more user friendly while "depends on" makes it easier to
disable options.
Usually I'm for the usage of "select" in such cases, but since this is
with CONFIG_EMBEDDED=y where users can be expected to know better what
they are doing I'd say a "depends on" is fine.
CONFIGFS_FS as a helper for some few file systems is also a different
situation from SYSFS that is a dependency of much more options.
> Linus
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists