linux-kernel - Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070708122137.GB30226@elte.hu>
Date:	Sun, 8 Jul 2007 14:21:37 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Avi Kivity <avi@...ranet.com>
Cc:	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Shaohua Li <shaohua.li@...el.com>
Subject: Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order


* Avi Kivity <avi@...ranet.com> wrote:

> From: Shaohua Li <shaohua.li@...el.com>
> 
> Need to flush the tlb after updating a pte, not before.

>  		rmap_remove(vcpu, spte);
> -		kvm_flush_remote_tlbs(vcpu->kvm);
>  		set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK);
> +		kvm_flush_remote_tlbs(vcpu->kvm);

hm, isnt this a must-have fix for v2.6.22 (and .21) as well?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/