[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <469121DA.6030600@redhat.com>
Date: Sun, 08 Jul 2007 10:41:46 -0700
From: Ulrich Drepper <drepper@...hat.com>
To: Al Viro <viro@....linux.org.uk>
CC: Markus Trippelsdorf <markus@...ppelsdorf.de>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference
- git-bisect result
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Al Viro wrote:
> Like hell. At the very least you want it to be opened for write.
> And even that is dubious, since "process has write access to file"
> is not quite the same thing as "somebody had given the process a
> descriptor opened for write".
But the real permissions tests are performed in notify_change. I think
all this is consistent with how, for instance, fchmod works. The
additional tests in fchmod which aren't here (IS_RDONLY and IS_APPEND)
would also apply to the case where a file name is given. So, either the
code was inconsistent already are these tests are really not needed.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFGkSHa2ijCOnn/RHQRAp0RAJ9ouvOd52feTPuFurxj8LzHZuGZsACgwxA8
ybEo1xmvakkKVenWc07PYhs=
=5DBy
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists