[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p73ir8uzpcx.fsf@bingen.suse.de>
Date: 08 Jul 2007 21:07:10 +0200
From: Andi Kleen <andi@...stfloor.org>
To: avi@...ranet.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RFC] kvm-scheduler integration
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@...lic.gmane.org> writes:
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 693f0e6..b705876 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -875,6 +875,10 @@ struct task_struct {
> pid_t pid;
> pid_t tgid;
>
> +#ifdef CONFIG_SCHED_KVM
> + struct kvm_vcpu *kvm_vcpu;
> +#endif
You should be careful to put this into a cache line that
is already touched during context switch. Otherwise
if it needs an additional cache miss it might become
very costly
Also it's a bit worrying to expose hooks into the scheduler
to any modules. How would others be stopped from abusing this?
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists