linux-kernel - Re: Coding style on function signatures (was: Convert tasklets to work queues )

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0707081209260.1536@fbirervta.pbzchgretzou.qr>
Date:	Sun, 8 Jul 2007 12:12:03 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Jim Cromie <jim.cromie@...il.com>
cc:	Linux kernel <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>, davem@...emloft.net
Subject: Re: Coding style on function signatures  (was: Convert tasklets to
 work queues )


On Jul 7 2007 18:49, Jim Cromie wrote:
> forex:
>
> static ssize_t
> store_fan_div (struct device *dev, struct device_attribute *devattr,
>                   const char *buf, size_t count)
> {...}
>
> IIRC, many like the entire sig on one line, because its grep friendly.
> I personally like the above, but grep-ability is hard to argue against.
>
> The above has 2 violations (of strict-grep-ability rule)
> 1 - return sig is separate

I can only think of one case where it's ok, when the first line is quite long
already:

static __attribute__((pure)) inline const uint32_t
hashfunction(parameter1, parameter2, ...)
{
}


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/