linux-kernel - Re: [PATCH][RFC] kvm-scheduler integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jul 2007 12:46:17 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Shaohua Li <shaohua.li@...el.com>
CC:	kvm-devel@...ts.sourceforge.net, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RFC] kvm-scheduler integration

Shaohua Li wrote:
> On Sun, 2007-07-08 at 20:58 +0800, Avi Kivity wrote:
>   
>> The only fly in the ointment is that it crashes quite soon.  Haven't
>> figured
>> out why yet, but comments on the general direction would be welcome.
>>     
> Attached patch seems help in my test. prepare_task_switch is called with
> irq disabled.
>
>
>   

Thanks!!  Will integrate that.


>> -static void vmx_vcpu_load(struct kvm_vcpu *vcpu)
>> +static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>>  {
>>         u64 phys_addr = __pa(vcpu->vmcs);
>> -       int cpu;
>>         u64 tsc_this, delta;
>>
>> -       cpu = get_cpu();
>> -
>> +       WARN_ON(!preempt_count());
>>     
> This and below change will break preempt disabled case. better remove
> them.
>   


Right.  Will take them out.



-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/