linux-kernel - Re: Makefiles for GNU make (Re: [PATCH] LinuxPPS (with new syscalls API)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070709105759.GL11451@enneenne.com>
Date:	Mon, 9 Jul 2007 12:57:59 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Oleg Verych <olecom@...wer.upol.cz>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Makefiles for GNU make (Re: [PATCH] LinuxPPS (with new
	syscalls API) - new version)

On Mon, Jul 09, 2007 at 12:56:11PM +0200, Oleg Verych wrote:
> On Mon, Jul 09, 2007 at 11:16:43AM +0200, Rodolfo Giometti wrote:
> > On Sun, Jul 08, 2007 at 11:05:32AM +0200, Oleg Verych wrote:
> > > * Rodolfo Giometti (Thu, 28 Jun 2007 18:14:50 +0200)
> > > * Organization: GNU/Linux Device Drivers, Embedded Systems and Courses
> > > 
> > > > +.PHONY : all depend dep
> > > > +
> > > > +all : .depend $(TARGETS)
> > > > +
> > > > +.depend depend dep :
> > > > +	$(CC) $(CFLAGS) -M $(TARGETS:=.c) > .depend
> > > []
> > > > +# -- Clean section ------------------------------------------------------------
> > > > +
> > > > +.PHONY : clean
> > > > +
> > > > +clean :
> > > > +	rm -f *.o *~ core .depend
> > > 
> > > Please see how currently .PHONY targets are used correctly, e.g. in
> > > linux/Makefile.
> > 
> > I don't understand why you wish I use linux PHONY targets management
> 
> Sorry i was not clear. Problem is `GNU make'[0], not management.
> 
> [0] <http://article.gmane.org/gmane.comp.gnu.make.bugs/2481>
> 
> > in a documentation Makefile... I suppose you are talking about
> > linux/Documentation/pps/Makefile which is just an example about people
> > may compile some testing/debugging programs. :-o
> 
> So, after this example you may write correct Makefiles for `GNU make'.

I see... but I'm still a bit confused... if I well understand I should
change the Makefile as follow:

   diff --git a/Documentation/pps/Makefile b/Documentation/pps/Makefile
   index a2660a2..d766447 100644
   --- a/Documentation/pps/Makefile
   +++ b/Documentation/pps/Makefile
   @@ -6,7 +6,7 @@ CFLAGS += -ggdb
    
    # -- Actions section ---------------------------------------------------------- 
   -.PHONY : all depend dep
   +.PHONY : depend dep
    
    all : .depend $(TARGETS)
    
   @@ -20,8 +20,6 @@ endif
    
    # -- Clean section ------------------------------------------------------------ 
   -.PHONY : clean
   -
    clean :
           rm -f *.o *~ core .depend
           rm -f ${TARGETS}

Is that right?

Thanks,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/