linux-kernel - Re: [2.6 patch] include/asm-mips/processor.h: "extern inline" -> "static inline"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cda58cb80707090440u1d320fc0u1cc04f95a443e226@mail.gmail.com>
Date:	Mon, 9 Jul 2007 13:40:40 +0200
From:	"Franck Bui-Huu" <vagabon.xyz@...il.com>
To:	"Ralf Baechle" <ralf@...ux-mips.org>
Cc:	"Adrian Bunk" <bunk@...sta.de>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] include/asm-mips/processor.h: "extern inline" -> "static inline"

Hi,

On 7/9/07, Ralf Baechle <ralf@...ux-mips.org> wrote:
> On Sat, Jul 07, 2007 at 03:03:30AM +0200, Adrian Bunk wrote:
>
> > "extern inline" will have different semantics with gcc 4.3,
> > and "static inline" is correct here.
>
> The idea was to have a linker error in case gcc should deciede for some
> reason not to inline this function which as I understand will continue
> to be the behaviour of gcc 4.3?
>

I don't know for this peculiar case but it usually is a good thing to
let gcc decide if the function needs to be inlined or not.

If we really want this function to be inlined in all cases, maybe we
should use __always_inline attribute instead ?

-- 
               Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/