linux-kernel - Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184003146.2453.29.camel@dhcp193.mvista.com>
Date:	Mon, 09 Jul 2007 10:45:46 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code

On Tue, 2007-07-03 at 17:16 -0700, Andrew Morton wrote:
> On Wed, 4 Jul 2007 02:14:42 +0200 (CEST) Jiri Kosina <jkosina@...e.cz> wrote:
> 
> > From: Jiri Kosina <jkosina@...e.cz>
> > 
> > Two trivial whitespace fixes in lockdep/spinlock code
> > 
> > Cc: Ingo Molnar <mingo@...e.hu>
> > Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> > 
> > diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> > index 1a5ff22..12ca5fd 100644
> > --- a/kernel/lockdep.c
> > +++ b/kernel/lockdep.c
> > @@ -1222,7 +1222,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
> >  
> >  	/*
> >  	 * Debug-check: all keys must be persistent!
> > - 	 */
> > +	 */
> >  	if (!static_obj(lock->key)) {
> >  		debug_locks_off();
> >  		printk("INFO: trying to register non-static key.\n");
> > diff --git a/kernel/spinlock.c b/kernel/spinlock.c
> > index 2c6c2bf..5386d7e 100644
> > --- a/kernel/spinlock.c
> > +++ b/kernel/spinlock.c
> > @@ -28,7 +28,7 @@ int __lockfunc _spin_trylock(spinlock_t *lock)
> >  		spin_acquire(&lock->dep_map, 0, 1, _RET_IP_);
> >  		return 1;
> >  	}
> > -	
> > +
> >  	preempt_enable();
> >  	return 0;
> >  }
> 
> Too trivial, sorry: we could generate 8 million patches like this.

Would you rather have one big patch that fixes a lot of this type of
stuff, or not have these types of patches at all ?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/