[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4691D8A2.2040706@qumranet.com>
Date: Mon, 09 Jul 2007 09:41:38 +0300
From: Avi Kivity <avi@...ranet.com>
To: Andi Kleen <andi@...stfloor.org>
CC: linux-kernel@...r.kernel.org, KVM <kvm-devel@...ts.sourceforge.net>
Subject: Re: [PATCH][RFC] kvm-scheduler integration
[cc list restored]
Andi Kleen wrote:
> Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@...lic.gmane.org> writes:
>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index 693f0e6..b705876 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -875,6 +875,10 @@ struct task_struct {
>> pid_t pid;
>> pid_t tgid;
>>
>> +#ifdef CONFIG_SCHED_KVM
>> + struct kvm_vcpu *kvm_vcpu;
>> +#endif
>>
>
> You should be careful to put this into a cache line that
> is already touched during context switch. Otherwise
> if it needs an additional cache miss it might become
> very costly
>
Yeah, I'll look into task_struct again to find a good place.
> Also it's a bit worrying to expose hooks into the scheduler
> to any modules. How would others be stopped from abusing this?
>
The functions for installing a hook are out-of-line and
EXPORT_SYMBOL_GPL'ed, in case that helps.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists