linux-kernel - [PATCH] fs: 9p/conv.c error path fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200707091024.26763.m.kozlowski@tuxland.pl>
Date:	Mon, 9 Jul 2007 10:24:26 +0200
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	ericvh@...il.com, rminnich@...l.gov, lucho@...kov.net,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [PATCH] fs: 9p/conv.c error path fix

Hello,

	When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 fs/9p/conv.c |    1 +
 1 file changed, 1 insertion(+)

diff -U 4 -pr linux-2.6.22-rc6-mm1-a/fs/9p/conv.c linux-2.6.22-rc6-mm1-b/fs/9p/conv.c
--- linux-2.6.22-rc6-mm1-a/fs/9p/conv.c	2007-06-25 01:21:48.000000000 +0200
+++ linux-2.6.22-rc6-mm1-b/fs/9p/conv.c	2007-07-09 09:59:37.000000000 +0200
@@ -741,8 +741,9 @@ struct v9fs_fcall *v9fs_create_twrite(u3
 	err = v9fs_put_user_data(bufp, data, count, &fc->params.twrite.data);
 	if (err) {
 		kfree(fc);
 		fc = ERR_PTR(err);
+		goto error;
 	}
 
 	if (buf_check_overflow(bufp)) {
 		kfree(fc);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/