linux-kernel - Re: [PATCH 1/4] try parent numa_node at first before using default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070710044911.GB10748@kroah.com>
Date:	Mon, 9 Jul 2007 21:49:11 -0700
From:	Greg KH <greg@...ah.com>
To:	Christoph Lameter <clameter@....com>
Cc:	Yinghai Lu <Yinghai.Lu@....COM>, akpm@...ux-foundation.org,
	ak@...e.de, rientjes@...gle.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] try parent numa_node at first before using default

On Mon, Jul 09, 2007 at 05:52:34PM -0700, Christoph Lameter wrote:
> On Mon, 9 Jul 2007, Greg KH wrote:
> 
> > > @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n)
> > >  
> > >  void device_initialize(struct device *dev)
> > >  {
> > > +	int node;
> > > +
> > >  	kobj_set_kset_s(dev, devices_subsys);
> > >  	kobject_init(&dev->kobj);
> > >  	klist_init(&dev->klist_children, klist_children_get,
> > > @@ -557,7 +559,9 @@ void device_initialize(struct device *dev)
> > >  	spin_lock_init(&dev->devres_lock);
> > >  	INIT_LIST_HEAD(&dev->devres_head);
> > >  	device_init_wakeup(dev, 0);
> > > -	set_dev_node(dev, -1);
> > > +
> > > +	node = dev->parent ? dev_to_node(dev->parent) : -1;
> > > +	set_dev_node(dev, node);
> > >  }
> > 
> > What is this going to give us?
> > 
> > Doesn't it mean that all devices will end up on the same node?
> 
> It means that the node for the device is the same as the parent device.
> F.e. if the parent device is a bus that is connected to node 4 then all 
> the devices hooked up to the bus are allocated on that node.

Yes, but is someone setting the parent device node information properly?

And this really needs some more changelog information please.  Why is
this needed from how things are done today?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/