[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070710090524.GK11115@waste.org>
Date: Tue, 10 Jul 2007 04:05:24 -0500
From: Matt Mackall <mpm@...enic.com>
To: Satyam Sharma <ssatyam@....iitk.ac.in>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Keiichi Kii <k-keiichi@...jp.nec.com>,
Netdev <netdev@...r.kernel.org>,
Joel Becker <joel.becker@...cle.com>,
Stephen Hemminger <shemminger@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 -mm 2/9] netconsole: Remove bogus check
On Tue, Jul 10, 2007 at 02:49:30PM +0530, Satyam Sharma wrote:
> From: Satyam Sharma <ssatyam@....iitk.ac.in>
>
> [2/9] netconsole: Remove bogus check
>
> The (!np.dev) check in write_msg() is bogus (always false), because:
> np.dev is set by netpoll_setup(), which is called by the target init
> code in init_netconsole() _before_ register_console() => write_msg() cannot
> be triggered unless netpoll_setup() returns with success. And that will not
> happen if netpoll_setup() failed to set np.dev. Also np.dev cannot go from
> under us while netconsole is loaded. This is because netpoll_setup() grabs
> a reference for us on that dev. So let's remove the pointless check.
>
> Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in>
> Cc: Keiichi Kii <k-keiichi@...jp.nec.com>
Acked-by: Matt Mackall <mpm@...enic.com>
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists