linux-kernel - [2.6 patch] i386: intel_cacheinfo.c:find_num_cache_leaves() should be _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070710124444.GW3492@stusta.de>
Date:	Tue, 10 Jul 2007 14:44:44 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	linux-kernel@...r.kernel.org
Subject: [2.6 patch] i386: intel_cacheinfo.c:find_num_cache_leaves() should
	be __cpuinit

This patch fixes the following section mismatch:

<--  snip  -->

...
  MODPOST vmlinux
WARNING: arch/i386/kernel/built-in.o(.text+0xb6a7): Section mismatch: reference to .init.text:find_num_cache_leaves (between 'init_intel_cacheinfo' and 'cache_shared_cpu_map_setup')
...

<--  snip  -->

It could be __init_refok, but gcc >= 4.0 anyway inlines it into the 
__cpuinit init_intel_cacheinfo(), and IMHO it's too small
for "noinline __init".

Signed-off-by: Adrian Bunk <bunk@...sta.de>

---
--- linux-2.6.22-rc6-mm1/arch/i386/kernel/cpu/intel_cacheinfo.c.old	2007-07-10 04:21:03.000000000 +0200
+++ linux-2.6.22-rc6-mm1/arch/i386/kernel/cpu/intel_cacheinfo.c	2007-07-10 04:24:27.000000000 +0200
@@ -275,8 +275,7 @@
 	return 0;
 }
 
-/* will only be called once; __init is safe here */
-static int __init find_num_cache_leaves(void)
+static int __cpuinit find_num_cache_leaves(void)
 {
 	unsigned int		eax, ebx, ecx, edx;
 	union _cpuid4_leaf_eax	cache_eax;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/