linux-kernel - Re: [PATCH] LinuxPPS (with new syscalls API)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184083547.32628.4.camel@pmac.infradead.org>
Date:	Tue, 10 Jul 2007 17:05:47 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] LinuxPPS (with new syscalls API) - new version

On Mon, 2007-07-09 at 15:19 +0200, Rodolfo Giometti wrote:
> 
> > Also read Documentation/volatile-considered-harmful.txt and ponder
> > deeply your use of 'volatile' on certain members of struct pps_s.
> 
> I read such document but I'm still convinced that the attribute
> volatile is needed for {assert,clear}_sequence and {assert,clear}_tu
> since inside pps_event() they are updated without any locks at all
> thanks to the dummy_info variable which is used for unallocated PPS
> sources.

I'm sure the version with 'volatile' will also be broken then. Sounds
like the right answer is to fix the locking.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/