linux-kernel - Re: [x86 setup 20/33] Console-writing code for the new x86 setup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0707102033060.11053@fbirervta.pbzchgretzou.qr>
Date:	Tue, 10 Jul 2007 20:35:32 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	"H. Peter Anvin" <hpa@...or.com>
cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	andi@...stfloor.org, akpm@...ux-foundation.org
Subject: Re: [x86 setup 20/33] Console-writing code for the new x86 setup
 code


On Jul 9 2007 19:51, H. Peter Anvin wrote:
>+
>+static inline int isdigit(int ch)
>+{
>+	return (ch >= '0') && (ch <= '9');
>+}

I'd say static inline unsigned int isdigit(unsigned char), since ASCII does not
realistically exceed 255.

>+static int strnlen(const char *s, int maxlen)

unsigned int,  and               unsigned int, too?
The glibc strnlen type also uses unsigned types.




	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/