linux-kernel - Re: [PATCH] UBI: cleanup usage of try_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1184145471.3531.88.camel@sauron>
Date:	Wed, 11 Jul 2007 12:17:51 +0300
From:	Artem Bityutskiy <dedekind@...radead.org>
To:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] UBI: cleanup usage of try_module_get

On Wed, 2007-07-11 at 17:11 +0900, Fernando Luis Vázquez Cao wrote:
> The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
> offer real protection against unexpected driver unloads, since we could
> be preempted before try_modules_get gets executed. It is the caller who
> should manipulate the refcounts. Besides, ubi_get_device_info is an
> exported symbol which guarantees protection when accessed through
> symbol_get.

Yeah, looks fair, committed to UBI git, thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/