[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070711101245.GA18770@dnb.sw.ru>
Date: Wed, 11 Jul 2007 14:12:45 +0400
From: Dmitry Monakhov <dmonakhov@...ru>
To: Christoph Hellwig <hch@...radead.org>,
Hugh Dickins <hugh@...itas.com>, Jes Sorensen <jes@....com>,
linux-kernel@...r.kernel.org
Subject: Re: [patch] mm: recheck lock rlim after f_op->mmap() method
On 10:32 Срд 11 Июл , Christoph Hellwig wrote:
> On Tue, Jul 10, 2007 at 06:27:05PM +0100, Hugh Dickins wrote:
> > On Mon, 9 Jul 2007, Dmitry Monakhov wrote:
> > > Some device drivers can change vm_flags in their f_op->mmap
> > > method. In order to be on the safe side we have to recheck
> > > lock rlimit. Now we have to check lock rlimit from two places,
> > > let's move this common code to helper functon.
> > >
> > > Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> > > ---
> > > mm/mmap.c | 33 ++++++++++++++++++++++++++-------
> > > 1 files changed, 26 insertions(+), 7 deletions(-)
> >
> > Or would this simpler patch be the right one? I suspect the
> > mspec driver only says VM_LOCKED because of a deep-seated but
> > irrational fear that its pages might fall into reclaim.
>
> Looks good. We probably should add a debug check to do_mmap_pgoff
> so that ->mmap methods don't change flags that are not for drivers.
As result fglrx totally goes crazy, because it change vm_flags
even from ->nopage() calback :)
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists