linux-kernel - Re: [PATCH 2.6.22-rc6-mm1] kallsyms: make KSYM_NAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4694B7EF.6040606@grupopie.com>
Date:	Wed, 11 Jul 2007 11:58:55 +0100
From:	Paulo Marques <pmarques@...popie.com>
To:	Tejun Heo <htejun@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.22-rc6-mm1] kallsyms: make KSYM_NAME_LEN include space
 for trailing '\0'

Tejun Heo wrote:
> KSYM_NAME_LEN is peculiar in that it does not include the space for
> the trailing '\0', forcing all users to use KSYM_NAME_LEN + 1 when
> allocating buffer.  This is nonsense and error-prone.  Moreover, when
> the caller forgets that it's very likely to subtly bite back by
> corrupting the stack because the last position of the buffer is always
> cleared to zero.
> 
> This patch increments KSYM_NAME_LEN by one and updates code
> accordingly.

Nice work.

I've been wanting to do that cleanup myself for a long time ;)

Acked-by: Paulo Marques <pmarques@...popie.com>

-- 
Paulo Marques - www.grupopie.com

"You're just jealous because the voices only talk to me."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/