linux-kernel - Re: [PATCH] Optimize struct task_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73d4yzyvkw.fsf@bingen.suse.de>
Date:	11 Jul 2007 14:27:11 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	nagar@...son.ibm.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Optimize struct task_delay_info

"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com> writes:
> replace them;
> 2) Delete lock. The change to the protected data has no nested cases.
> In addition, the result is for performance data collection, so it’s
> unnecessary to add such lock. 

Not sure that's a good idea. People expect their performance counts
to be accurate too. You could possibly use atomics though, but 
when there are multiple counters updated the spinlock will be likely
faster.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/