[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1184154877.6462.6.camel@heimdal.trondhjem.org>
Date: Wed, 11 Jul 2007 07:54:37 -0400
From: Trond Myklebust <trond.myklebust@....uio.no>
To: Christoph Hellwig <hch@...radead.org>
Cc: Mingming Cao <cmm@...ibm.com>, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
nfsv4@...ux-nfs.org
Subject: Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update
On Wed, 2007-07-11 at 09:47 +0100, Christoph Hellwig wrote:
> On Sun, Jul 01, 2007 at 03:37:45AM -0400, Mingming Cao wrote:
> > This patch is on top of i_version_update_vfs.
> > The i_version field of the inode is set on inode creation and incremented when
> > the inode is being modified.
>
> Which is not what i_version is supposed to do. It'll get you tons of misses
> for NFSv3 filehandles that rely on the generation staying the same for the
> same file. Please add a new field for the NFSv4 sequence counter instead
> of making i_version unuseable.
Aren't you confusing i_version and i_generation here? Those are two
separate inode fields.
Cheers
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists