linux-kernel - Re: [PATCH] serial: do not add port that is not initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707111005.53836.bjorn.helgaas@hp.com>
Date:	Wed, 11 Jul 2007 10:05:53 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Yinghai Lu <Yinghai.Lu@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: do not add port that is not initialized

On Wednesday 11 July 2007 01:17:42 am Russell King wrote:
> On Tue, Jul 10, 2007 at 05:03:35PM -0700, Yinghai Lu wrote:
> > [PATCH] serial: do not add port that is not initialized
> > 
> > if the port is not initialized with correct iobase, and membase, we don't
> > need to add that port.
> > for x86, when pnpacpi is enabled, we will not get extra ttyS1/ttyS2/ttyS3 in
> > /sys/devices/platform/serial8250/tty
> > 
> > Sign-off-by: Yinghai Lu <yinghai.lu@....com>
> 
> What if someone wants to run setserial on /dev/ttyS1 to set it's base
> address, irq and other parameters?  People still do this.

I agree that people still use setserial that way, and we shouldn't
make this change because it would break things.

But I also agree with Yinghai that these extra phantom devices are
just weird.  It would be a lot nicer if there were a way to say,
"please, Mr. Serial Driver, create me a new ttyS device with these
parameters."

But no, I'm not volunteering to do that.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/